View Issue Details

IDProjectCategoryView StatusLast Update
0000957Composr[All Projects] General / Uncategorisedpublic2013-08-14 19:03
ReporterLhasadreamsAssigned ToChris Graham 
SeverityMinor-bug 
Status resolvedResolutionfixed 
Product Version 
Fixed in Version 
Summary0000957: Cannot select a user name in the To field of a private topic in Conversr
DescriptionHi,
Using an iPad or iPhone in full or mobile mode the drop down doesn't work.

In fact it does not work for the Product Version drop down on this form either.

Cheers,
Ade
Steps To ReproduceGo to http://vwgolfmk1.org.uk/ join up if not a member.

Start a new Private topic.

Start typing in the To box.

A small drop down appears but it is never filled with a username.

As long as you know the username you can keep typing and the system users it.

This happens in other areas of the forum as well, I guess it is a common feature.
TagsNo tags attached.
Time estimation (hours)
Sponsorship open

Activities

Chris Graham

2013-01-02 18:02

administrator   ~0001121

This is now fixed, but I am actually going to roll the changes into the other iPhone issue, as I fixed some other iOS issues I found at the same time.

Lhasadreams

2013-08-14 13:52

reporter   ~0001619

Hi Chris,
This issue has regressed on our site - I am not sure when it happened though.

Can you detail the changes that are required so that I can reapply it please.

Cheers
Ade

Chris Graham

2013-08-14 18:22

administrator   ~0001623

Yes it did seem to revert.

This fixes it, better than it would have been before...

diff --git a/themes/default/templates/JAVASCRIPT.tpl b/themes/default/templates/JAVASCRIPT.tpl
index 92c8d30..7d78871 100644
--- a/themes/default/templates/JAVASCRIPT.tpl
+++ b/themes/default/templates/JAVASCRIPT.tpl
@@ -867,7 +867,7 @@ function browser_matches(code)
        switch (code)
        {
                case 'ios':
- return browser.indexOf('iphone')!=-1;
+ return browser.indexOf('iphone')!=-1 || browser.indexOf('ipad')!=-1;
                case 'android':
                        return browser.indexOf('android')!=-1;
                case 'wysiwyg':
diff --git a/themes/default/templates/JAVASCRIPT_AJAX_PEOPLE_LISTS.tpl b/themes/default/templates/JAVASCRIPT_AJAX_PEOPLE_LISTS.tpl
index a719873..bbe315d 100755
--- a/themes/default/templates/JAVASCRIPT_AJAX_PEOPLE_LISTS.tpl
+++ b/themes/default/templates/JAVASCRIPT_AJAX_PEOPLE_LISTS.tpl
@@ -25,6 +25,15 @@ function close_down()
 
 window.currently_doing_list=null;
 
+add_event_listener_abstract(window,'load',function () {
+ var es=document.getElementsByTagName('input');
+ for (var i=0;i<es.length;i++)
+ {
+ if (es[i].getAttribute('autocomplete')=='off')
+ es[i].setAttribute('autocorrect','off');
+ }
+} );
+
 function update_ajax_member_list(target,special,delayed,e)
 {
        if (typeof e=='undefined') var e=window.event;
@@ -36,6 +45,7 @@ function update_ajax_member_list(target,special,delayed,e)
        if (e && enter_pressed(e)) return null;
 
        target.setAttribute('autocomplete','off');
+ target.setAttribute('autocorrect','off');
        if (target.disabled) return;
 
        if (!browser_matches('ios'))


The main change is the first, letting iPad detect as iOS.

Lhasadreams

2013-08-14 19:03

reporter   ~0001625

Cheers Chris, that is much better mate

Issue History

Date Modified Username Field Change
2023-02-26 18:29 Chris Graham Category General => General / Uncategorised