View Issue Details

IDProjectCategoryView StatusLast Update
0000651ocProducts non-bundled addons[All Projects] Generalpublic2018-09-07 01:34
ReporterChris GrahamAssigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status non-assignedResolutionopen 
Summary0000651: Sync with upstream
DescriptionWe use a number of large packages in Composr addons. Sometimes we want to patch these, however that puts us out of sync. Regularly we get code quality validation issues (e.g. use of 'ereg') in them that could cause issues for people.

See if we can automatically sync with the projects and push patches to them. Where appropriate using proper github forks under the ocProducts account with pull requests in branches.

The list is on Google Docs:
https://docs.google.com/spreadsheets/d/1Im6ICITZmzoBVMizD0CkM7N0kXH5Rb-NQJzD1hk49cU/edit#gid=0
Additional InformationUsing git submodules direct within our repository was considered, but considered too complicated.

Remember to update .editorconfig and line_count.sh and licence.txt and phpdoc.dist.xml and https://docs.google.com/spreadsheets/d/1Im6ICITZmzoBVMizD0CkM7N0kXH5Rb-NQJzD1hk49cU/edit#gid=0 and automated test skipping and maintenance_sheet.csv too (as appropriate).
TagsNo tags attached.
Attach Tags
Time estimation (hours)40
Sponsorship open

Relationships

related to 0002578 resolvedChris Graham Composr Official non-maintained status 
related to 0003671 non-assigned Composr Cookie Consent Update 
related to 0003294 non-assigned ocProducts non-bundled addons Facebook SDK needs replacing 

Activities

Chris Graham

2017-06-22 00:03

administrator   ~0005143

When CkEditor is upgraded hopefully it will support CSP, so we don't have to disable inline JS when CkEditor is loaded up.

KingBast

2018-08-31 20:35

administrator   ~0005803

Just a note that moment.js isn't on the spreadsheet and seems to be bundled. Not sure where it's used so maybe it's not considered important in Composr but it does a great live time and date display on a theme I bought recently. Would love to see that happen with the commented out localized {TIME} in GLOBAL_HTML_WRAP.tpl which is currently a static timestamp at pageload.

Chris Graham

2018-09-07 01:34

administrator   ~0005820

I don't believe moment.js is used, I just searched the v11 branch and found references - and I have no memory of us using it.

Issue History

Date Modified Username Field Change
2016-08-03 12:32 Chris Graham Description Updated View Revisions
2016-08-03 12:32 Chris Graham Additional Information Updated View Revisions
2016-08-03 12:35 Chris Graham Description Updated View Revisions
2016-10-05 23:25 Chris Graham Relationship added related to 0002578
2016-12-12 10:04 Chris Graham Description Updated View Revisions
2016-12-12 10:05 Chris Graham Additional Information Updated View Revisions
2017-04-26 22:25 Chris Graham Description Updated View Revisions
2017-06-22 00:03 Chris Graham Note Added: 0005143
2017-07-09 14:01 Chris Graham Description Updated View Revisions
2017-07-09 14:01 Chris Graham Additional Information Updated View Revisions
2017-07-09 14:11 Chris Graham Additional Information Updated View Revisions
2018-02-07 21:14 Chris Graham Relationship added related to 0003294
2018-03-07 00:45 Chris Graham Additional Information Updated View Revisions
2018-03-07 00:46 Chris Graham Additional Information Updated View Revisions
2018-08-31 17:02 Chris Graham Relationship added related to 0003671
2018-08-31 20:35 KingBast Note Added: 0005803
2018-09-07 01:34 Chris Graham Note Added: 0005820
2018-10-03 00:59 KingBast Note View State: 0005803: public