Pagination Error
Standard member
Had this one around for a wee while but hadn't gotten around to asking. Anyone experienced this bad boy:
100% recreatable on every page pagination is used. Sorry for the delay in reporting; it's been around for the last 5+ releases or so. I get it on a fresh (read: not yet mangled by me
) installation as well. Unfortunately my Javascript sux worse than my PHP so I'm not much help in troubleshooting.Thanx!
"no violence, no hate, no pain, no enemies
just peace, unity, tolerance and love" - The Beloved
just peace, unity, tolerance and love" - The Beloved
Standard member
"no violence, no hate, no pain, no enemies
just peace, unity, tolerance and love" - The Beloved
just peace, unity, tolerance and love" - The Beloved
Site director
Do you have an overridden template that is including AJAX_PAGINATION?
I think there was a bug with this a while back, but it was fixed.
Anything including the template should be passing a WRAPPER_ID, e.g.
Code
{+START,INCLUDE,AJAX_PAGINATION}
ALLOW_INFINITE_SCROLL=1
WRAPPER_ID={$GET,ajax_block_main_activities_wrapper}
{+END}
Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon
- If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
- If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
- If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
- If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Standard member
Code
{$GET%,wrapper_id}Code
{WRAPPER_ID%}
"no violence, no hate, no pain, no enemies
just peace, unity, tolerance and love" - The Beloved
just peace, unity, tolerance and love" - The Beloved
Site director
Sorry for the delay in replying, this got stuck too far down my todo list.
I'm not convinced there's an active bug here, I think I didn't communicate what I meant clearly enough.
Maybe this commit will clarify what has happened:
https://github.com/ocproducts/composr/commit/71c30fb108897aecb20eb310cbd3bfb516e5c14f
Before Jul 31, 2018, there was an issue whereby nested paginations would mess up, because we were setting IDs based on shared variables (creating a conflict). So I instead switched it to so each template would assign a template-specific ID.
Any of the changed templates overridden from an earlier patch would have lost compatibility at this point. I suspect you have one or more of them overridden.
The Tempcode that loads up AJAX_PAGINATION passes through WRAPPER_ID now, as used by the new version of that template.
Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon
- If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
- If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
- If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
- If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Standard member
Site director
Paul Flavel said
I know this is something that is affecting the themes i made, so will go through them all and update with the above. I will also include the instructions on how to manually fix them for those who have further customised their theme.
From “Post #5,573”, 12th February 2019, 12:02 am
Sorry for the inconvenience, thanks for doing that.
Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon
- If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
- If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
- If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
- If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Standard member
1 guest and 0 members have just viewed this.
