Youtube video is not responsive

Post

Posted
Rating:
#2064 (In Topic #396)
Avatar
Standard member
lifeguard is in the usergroup ‘Fan in training’
Hey guys :)

First, i realy like the new compo.sr 
i am testing in a sub dir, and the first thing i see, is that youtube video is not responsive.
on a mobile device i see half of the video.

is it possible to fix this, or is there already a solution?
Online now: No Back to the top

Post

Posted
Rating:
#2078
Avatar
Site director
Chris Graham is in the usergroup ‘Administrators’
Hi :),

You're right, it's clumsy right now.

I have just incorporated a change for the next patch release. When on desktop mode videos will play as they do now (specific size), but on mobile mode they'll use a 'responsive' technique to take full width.

See:
https://github.com/ocproducts/composr/commit/7e759cbd6a69a84d95aa13d27d3f9eb9ec552a2f

You'll need to copy the changes I made into your theme's global.css.

You'll also need to pass the content through an edit so that the Comcode refreshes.



Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon

Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Online now: No Back to the top

Post

Posted
Rating:
#2080
Avatar
Site staff
Adam Edington is in the usergroup ‘Super-moderators’
Will this change also work on the MediaElement addon? cos I have applied some hacks I discovered to make that responsive already.
Online now: No Back to the top

Post

Posted
Rating:
Item has a rating of 5 (Liked by Adam Edington)
#2084
Avatar
Site director
Chris Graham is in the usergroup ‘Administrators’
I only considered YouTube. I think for a normal HTML5 player (not one in an iframe like YouTube's) it would be pretty straight forward to make it responsive using simple CSS or just a 100% width.


Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon

Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Online now: No Back to the top

Post

Posted
Rating:
#2086
Avatar
Standard member
lifeguard is in the usergroup ‘Fan in training’
Yes, many thanks for your answer, and keep up this wonderful job!

edit: I tried your fix, but i dont see any changes.
i changed my css like you said, en de youtube file.
Upload all, edit the posts with youtube video, but on mobile its the same. Even after clear cache and all.

is there something that i do wrong?

Last edit: by lifeguard

Online now: No Back to the top

Post

Posted
Rating:
#2087
Avatar
Site director
Chris Graham is in the usergroup ‘Administrators’
Did you definitely edit the global.css file of the active theme? Are you able to use the browser's developer tools to inspect the YouTube player, you should see a 'div' with 'youtube_player' around it.


Become a fan of Composr on Facebook or add me as a friend. Add me on on Mastodon. Follow me on Minds (where I am most active). Support me on Patreon

Was I helpful?
  • If not, please let us know how we can do better (please try and propose any bigger ideas in such a way that they are fundable and scalable).
  • If so, please let others know about Composr whenever you see the opportunity or support me on Patreon.
  • If my reply is too Vulcan or expressed too much in business-strategy terms, and not particularly personal, I apologise. As a company & project maintainer, time is very limited to me, so usually when I write a reply I try and make it generic advice to all readers. I'm also naturally a joined-up thinker, so I always express my thoughts in combined business and technical terms. I recognise not everyone likes that, don't let my Vulcan-thinking stop you enjoying Composr on fun personal projects.
  • If my response can inspire a community tutorial, that's a great way of giving back to the project as a user.
Online now: No Back to the top

Post

Posted
Rating:
#2099
Avatar
Standard member
lifeguard is in the usergroup ‘Fan in training’
Hi Chris,

Please call me stupid! I put the global.css in the css folder, but not in de custom_css
Now its working perfectly.
Thanks for your time. Have a nice day.
Online now: No Back to the top
1 guest and 0 members have just viewed this.

Statistics

Forum statistics:
  • 2,053 topics, 7,195 posts, 10,853 members
  • Our newest member is ledfactory
Birthdays:
Back to Top